feat: sharded peer manager #2151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SionoiS
added
the
E:1.4: Sharded peer management and discovery
|
You can find the image built from this PR at Built from ec08762 |
gabrielmer
reviewed
Oct 24, 2023
SionoiS
force-pushed
the
feat--sharded-peer-manager
branch
from
3b6a1bc
to
36866cd
Compare
alrevuelta
requested changes
Oct 25, 2023
|
I'm still looking at the tests. Some are easier to update than others. |
alrevuelta
approved these changes
Oct 27, 2023
Yes I won't be merging this without some simulations. These changes could have unforeseen consequences. |
SionoiS
force-pushed
the
feat--sharded-peer-manager
branch
2 times, most recently
from
eb0f52b
to
2947dab
Compare
jm-clius
approved these changes
Oct 30, 2023
SionoiS
force-pushed
the
feat--sharded-peer-manager
branch
from
b79983c
to
bc20db5
Compare
SionoiS
force-pushed
the
feat--sharded-peer-manager
branch
2 times, most recently
from
256ecd9
to
bfc4e13
Compare
6 tasks
SionoiS
force-pushed
the
feat--sharded-peer-manager
branch
from
bfc4e13
to
d464309
Compare
|
In order to unblock this work I've opened #2237 |
1 task
SionoiS
force-pushed
the
feat--sharded-peer-manager
branch
from
de36146
to
7580a6a
Compare
Fix possible out of bound & logic error Filter peers per protocol & rename proc Fix out of bound & refactor dialling Fix catching raise VS timeout & tests fixes Fix test to connect to all peer per proto Fix test Div target per shard count Logging & stuff Fixes Log peer count More logs Remove protobook override & clean up Fix relay peer management & logs Mics Fixes Fixes
SionoiS
force-pushed
the
feat--sharded-peer-manager
branch
from
7d0f2f7
to
1cf3a80
Compare
SionoiS
requested review from
gabrielmer,
jm-clius,
alrevuelta and
Ivansete-status
|
I've done simulations and this should be the final version of this feature. Sorry for the re-review but it's critical to get this right. |
3 tasks
alrevuelta
approved these changes
Dec 6, 2023
1 task
Ivansete-status
added a commit
that referenced
this pull request
Dec 20, 2023
This reverts commit dba9820. We need to revert this commit because the waku-simulator stopped working. i.e. the nodes couldn't establish connections among them: https://github.com/waku-org/waku-simulator/tree/054ba9e33f4fdcdb590bcfe760a5254069c5cb9f Also, the following js-waku test fails due to this commit: "same cluster, different shard: nodes connect"
Ivansete-status
added a commit
that referenced
this pull request
Dec 20, 2023
This reverts commit dba9820. We need to revert this commit because the waku-simulator stopped working. i.e. the nodes couldn't establish connections among them: https://github.com/waku-org/waku-simulator/tree/054ba9e33f4fdcdb590bcfe760a5254069c5cb9f Also, the following js-waku test fails due to this commit: "same cluster, different shard: nodes connect" * waku_lightpush/protocol.nim: minor changes to make it compile after revert
Ivansete-status
added a commit
that referenced
this pull request
Jan 9, 2024
This reverts commit dba9820. We need to revert this commit because the waku-simulator stopped working. i.e. the nodes couldn't establish connections among them: https://github.com/waku-org/waku-simulator/tree/054ba9e33f4fdcdb590bcfe760a5254069c5cb9f Also, the following js-waku test fails due to this commit: "same cluster, different shard: nodes connect" * waku_lightpush/protocol.nim: minor changes to make it compile after revert
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Peer manager must track peers per shard. Each with a target number of in/out peers and then connect/prune connections accordingly.
Changes
Tracking #1940