-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test(store): Implement store tests (2/2) #2240
Conversation
You can find the image built from this PR at
Built from 2067efb |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Broadly looks good to me. Thanks! Feel free to re-request review once the related issues are fixed and this is ready to merge.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Beautiful PR! Thanks for it! 💯
6028714
to
feb40f3
Compare
3dcfbf8
to
9b82f73
Compare
feb40f3
to
6bcab97
Compare
9b82f73
to
21f4cc7
Compare
6bcab97
to
a172987
Compare
21f4cc7
to
4e328af
Compare
699ca20
to
7a796c2
Compare
4ba660b
to
14f2317
Compare
f56ceb4
to
fdc2486
Compare
14f2317
to
d9f5623
Compare
fdc2486
to
c4f8834
Compare
d9f5623
to
0ba05b5
Compare
c4f8834
to
e20b308
Compare
0ba05b5
to
fe77338
Compare
Description
Implement second batch of store tests
Changes
Additional Notes
There are two tests, under the
Ephemeral
suite, which are commented. That's due to a bug for which I'm opening an issue right now.