Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(store): Implement store tests (2/2) #2240

Merged
merged 6 commits into from
Dec 19, 2023
Merged

Conversation

AlejandroCabeza
Copy link
Contributor

@AlejandroCabeza AlejandroCabeza commented Nov 23, 2023

Description

Implement second batch of store tests

Changes

  • Implement second batch of store tests

Additional Notes

There are two tests, under the Ephemeral suite, which are commented. That's due to a bug for which I'm opening an issue right now.

@AlejandroCabeza AlejandroCabeza self-assigned this Nov 23, 2023
@AlejandroCabeza AlejandroCabeza changed the title test(store): Implement store tests (2/2) test(store): Implement store tests (2/2) Nov 23, 2023
Copy link

github-actions bot commented Nov 23, 2023

You can find the image built from this PR at

quay.io/wakuorg/nwaku-pr:2240

Built from 2067efb

Copy link
Contributor

@jm-clius jm-clius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Broadly looks good to me. Thanks! Feel free to re-request review once the related issues are fixed and this is ready to merge.

@AlejandroCabeza AlejandroCabeza marked this pull request as ready for review November 24, 2023 10:37
Copy link
Collaborator

@Ivansete-status Ivansete-status left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beautiful PR! Thanks for it! 💯

@AlejandroCabeza AlejandroCabeza merged commit 6b6e323 into test-store Dec 19, 2023
8 checks passed
@AlejandroCabeza AlejandroCabeza deleted the test-store-2 branch December 19, 2023 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants