Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(rln): Implement some rln unit tests #2356

Merged
merged 8 commits into from
Feb 2, 2024
Merged

test(rln): Implement some rln unit tests #2356

merged 8 commits into from
Feb 2, 2024

Conversation

AlejandroCabeza
Copy link
Contributor

Description

Implement some basic unic tests for RLN

Changes

  • Add some rln tests
  • Fix KeysBuffer length check

@AlejandroCabeza AlejandroCabeza self-assigned this Jan 15, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 15, 2024 •
edited

You can find the image built from this PR at

quay.io/wakuorg/nwaku-pr:2356

Built from 4ca771e

gabrielmer
gabrielmer reviewed Jan 16, 2024
View reviewed changes
Copy link
Contributor

@gabrielmer gabrielmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks amazing! Added a couple minor comments.

Thanks so much!

tests/waku_rln_relay/rln/test_wrappers.nim Outdated Show resolved Hide resolved
tests/waku_rln_relay/rln/test_wrappers.nim Outdated Show resolved Hide resolved
rymnc
rymnc approved these changes Jan 21, 2024
View reviewed changes
Copy link
Contributor

@rymnc rymnc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gabrielmer gabrielmer self-requested a review January 25, 2024 16:17
gabrielmer
gabrielmer approved these changes Jan 25, 2024
View reviewed changes
Copy link
Contributor

@gabrielmer gabrielmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! 🚀

@AlejandroCabeza AlejandroCabeza merged commit f86baa0 into master Feb 2, 2024
10 checks passed
@AlejandroCabeza AlejandroCabeza deleted the test-rln branch February 2, 2024 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rymnc rymnc rymnc approved these changes

@gabrielmer gabrielmer gabrielmer approved these changes

Assignees

@AlejandroCabeza AlejandroCabeza

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@AlejandroCabeza @rymnc @gabrielmer