-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add tool to benchmark RLN proof generation/verification #2410
Conversation
You can find the image built from this PR at
Built from 8d1a614 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
std/sequtils, | ||
stew/results, | ||
options, | ||
../../waku/waku_rln_relay/protocol_types, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe we can just import waku_rln_relay?
apps/benchmarks/benchmarks.nim
Outdated
var proofGenTimes: seq[times.Duration] = @[] | ||
var proofVerTimes: seq[times.Duration] = @[] | ||
|
||
for i in 0 .. 50: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
in a future iteration can we have this configurable?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
imho no need to complicate things. this is intended for devs so just change the value and recompile :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome! Thanks!
apps/benchmarks/benchmarks.nim
Outdated
var proofVerTimes: seq[times.Duration] = @[] | ||
|
||
for i in 0 .. 50: | ||
var time = getTime() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In case we want to measue CPU-bounded tasks, it would be interesting to use cpuTime
instead.
538b211
to
3c3c838
Compare
Add simple tool to benchmark RLN proof generation and verification.
Run as:
Output: