chore(rln-relay-v2): added tests for onchain rln-relay-v2 #2482
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rymnc
force-pushed
the
onchain-rln-v2-tests
branch
from
c3106bc
to
e77c0b6
Compare
|
You can find the image built from this PR at Built from 1b070c6 |
rymnc
force-pushed
the
onchain-rln-v2-tests
branch
2 times, most recently
from
a1db50b
to
3c08096
Compare
rymnc
force-pushed
the
onchain-rln-v2-tests
branch
from
3c08096
to
11edcb6
Compare
rymnc
force-pushed
the
onchain-rln-v2-tests
branch
from
11edcb6
to
4685099
Compare
2 tasks
Ivansete-status
approved these changes
Feb 29, 2024
| raise newException(CatchableError, "failed to convert rateCommitments to leaves: " & leavesRes.error) | ||
| let leaves = cast[seq[seq[byte]]](leavesRes.get()) | ||
| let leaves = rateCommitments.toLeaves().valueOr: | ||
| raise newException(ValueError, "failed to convert rateCommitments to leaves: " & $error) |
There was a problem hiding this comment.
Unrelated to this PR but I'm more keen on avoid raising exceptions whenever is possible
There was a problem hiding this comment.
Will address in follow up prs!
Co-authored-by: Ivan FB <128452529+Ivansete-status@users.noreply.github.com>
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR includes changes to the
test_rln_group_manager_onchainwith fixes to some of the serde done at the event parsing side.Note
The rln-v2 test suite is not feature complete yet, i.e it has to be integrated in other test suites like
test_wakunode_rln_relay.nimandtest_waku_rln_relay.nim, those will be addressed in follow up PRsChanges
How to test
source env.shnim c --out:build/onchain_rln_test -r -d:chronicles_log_level=DEBUG -d:rln_v2:true -d:os=Darwin --verbosity:0 --hints:off -d:chronicles_log_level=TRACE -d:git_version="v0.24.0-rc.0-35-g50308e" -d:release --passL:librln_v0.4.1.a --passL:-lm tests/waku_rln_relay/test_rln_group_manager_onchain.nimIssue
closes #2481