Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(discv5): Implement discv5 tests #2487

Merged
merged 5 commits into from
Mar 14, 2024
Merged

test(discv5): Implement discv5 tests #2487

merged 5 commits into from
Mar 14, 2024

Conversation

AlejandroCabeza
Copy link
Contributor

Description

Extend discv5 tests and regroup existing ones.

Changes

  • Implement missing discv5 tests.
  • Regroup existing discv5 tests.
  • Make fromIndicesList public as it's very useful for a helper function (alternatives welcome).

Copy link

github-actions bot commented Feb 28, 2024

You can find the image built from this PR at

quay.io/wakuorg/nwaku-pr:2487-rln-v2-false

Built from f54dbe3

Copy link
Contributor

@SionoiS SionoiS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks

Copy link
Contributor

@jm-clius jm-clius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Thanks for this.

Copy link
Collaborator

@Ivansete-status Ivansete-status left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
Just nitpick comments:)

tests/waku_enr/test_sharding.nim Show resolved Hide resolved
tests/waku_discv5/test_waku_discv5.nim Show resolved Hide resolved
@AlejandroCabeza AlejandroCabeza merged commit 0894f0c into master Mar 14, 2024
14 of 15 checks passed
@AlejandroCabeza AlejandroCabeza deleted the test-discv5 branch March 14, 2024 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants