-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test(discv5): Implement discv5 tests #2487
Conversation
You can find the image built from this PR at
Built from f54dbe3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM thanks
23f5092
to
7c8c813
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great! Thanks for this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Just nitpick comments:)
55438a1
to
54ca8aa
Compare
7c8c813
to
858099c
Compare
761a297
to
68f9ec6
Compare
858099c
to
96b9410
Compare
96b9410
to
62f4e27
Compare
Description
Extend discv5 tests and regroup existing ones.
Changes
fromIndicesList
public as it's very useful for a helper function (alternatives welcome).