-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test(rln): Implement rln tests #2639
Draft
AlejandroCabeza
wants to merge
16
commits into
master
Choose a base branch
from
tests/rln
base: master
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
You can find the image built from this PR at
Built from 5e8baa5 |
You can find the image built from this PR at
Built from 5e8baa5 |
AlejandroCabeza
force-pushed
the
tests/rln
branch
from
May 13, 2024 17:21
0d2cec3
to
66e83b7
Compare
rymnc
reviewed
May 14, 2024
Comment on lines
73
to
79
asyncTest "should error if contract does not exist": | ||
let manager = await setup() | ||
manager.ethContractAddress = "0x0000000000000000000000000000000000000000" | ||
|
||
expect(CatchableError): | ||
await manager.init() | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this test already exists, i believe
AlejandroCabeza
force-pushed
the
tests/rln
branch
from
May 29, 2024 15:29
2e8d35d
to
e3d047d
Compare
This was referenced May 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Extend RLN tests coverage
Changes