-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: handle named sharding in enr #2647
Conversation
You can find the image built from this PR at
Built from ab5cdfe |
You can find the image built from this PR at
Built from ab5cdfe |
Aren't we only adding a log in this PR? Or am I missing something? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thank!
I just added a small nitpick comment
Nope, without this specific conditional..it goes into the else condition and causes issue reported in #2644 . |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks so much!
Description
fixes #2644