Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove deprecated RPC client/protocol #11

Merged
merged 4 commits into from
Jan 8, 2024
Merged

remove deprecated RPC client/protocol #11

merged 4 commits into from
Jan 8, 2024

Conversation

fbarbu15
Copy link
Collaborator

@fbarbu15 fbarbu15 commented Jan 5, 2024 •
edited

PR Details

  • Removing code related to the deprecated RPC protocol (that will soon be removed from waku as well)

@fbarbu15 fbarbu15 marked this pull request as ready for review January 5, 2024 15:55
AlejandroCabeza
AlejandroCabeza approved these changes Jan 5, 2024
View reviewed changes
Copy link

@AlejandroCabeza AlejandroCabeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fbarbu15 fbarbu15 merged commit 5b7045a into master Jan 8, 2024
1 of 2 checks passed
@fbarbu15 fbarbu15 deleted the chore/remote-rpc-client branch January 8, 2024 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlejandroCabeza AlejandroCabeza AlejandroCabeza approved these changes

@romanzac romanzac Awaiting requested review from romanzac

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@fbarbu15 @AlejandroCabeza