chore: RLN registration support #16

romanzac · 2024-02-05T06:19:46Z

PR Details

WakuNode extension to support RLN registration for Go/Nim Waku.

- mark volumes shared across containers

src/steps/relay.py

tests/relay/test_rln.py

fbarbu15

LGTM, thank you so much
Please make a CI run and add it in the PR comments before merging

- print out container log

- delete proper keys from default_args

romanzac · 2024-02-13T14:05:24Z

LGTM, thank you so much Please make a CI run and add it in the PR comments before merging

Last Ci run before merge
https://waku-org.github.io/waku-interop-tests/nim/12
https://github.com/waku-org/waku-interop-tests/actions/runs/7887269465

romanzac added 30 commits January 31, 2024 23:35

chore: parameters and volumes for RLN relay

4039480

chore: add startup test for RLN

aaa0342

fix: remove redundant rln_enabled from WakuNode

8b7e9ae

fix: - and _ magic in rln parameters

5480453

fix: key 'eth_testnet_key' -> 'eth_client_private_key'

cd9235a

fix: rln-register_only -> rln-register-only

a9080f9

fix: use extend instead of append for the volumes list

59d2252

fix: use absolute path for the volumes names

4cf303c

- mark volumes shared across containers

fix: remove :z attr from volumes

5d5f977

fix: remove filename from volume path

93f6456

fix: remove request for ENR

67bf590

test: plain RLN registration

5147a8a

fix: remove subscribe

9995c75

fix: remove ENR related params

942281f

test: add run_container func to Docker Mananger

24e34b0

fix: remove run_container func from Docker Mananger - no need for exec

0e6e620

fix: pass exec commands instead of specialized docker exec func

72307cb

fix: exclude RLN arguments from others

3a6b96d

fix: separate RLN volumes by implementation

c47ba4c

test: registration with nwaku

62e2b54

test: registration over existing credentials

54f6146

test: add RLN Relay node startup

42ea300

test: RLN credentials reuse for relay node startup

88206df

fix: clean up unnecessary commands

c5ddbcc

fix: clean up unnecessary commands for non RLN relay too

d1b627e

test: regression by sending one valid message

8ab9850

fix: add forgotten call to get enr_uri

0e7a483

fix: check RLN credentials set properly

651531f

fix: parenthesis in eval expression

728ee2d

fix: better check for RLN credentials

f7bb8d0

test: RLN_CREDENTIALS env var example

01d87a9

fbarbu15 reviewed Feb 8, 2024

View reviewed changes

src/steps/relay.py Outdated Show resolved Hide resolved

fbarbu15 reviewed Feb 8, 2024

View reviewed changes

src/steps/relay.py Outdated Show resolved Hide resolved

fbarbu15 reviewed Feb 8, 2024

View reviewed changes

src/steps/relay.py Outdated Show resolved Hide resolved

fbarbu15 reviewed Feb 8, 2024

View reviewed changes

tests/relay/test_rln.py Outdated Show resolved Hide resolved

romanzac added 5 commits February 9, 2024 10:53

fix: check_rln_registration to raise exception

0f593cc

fix: use f-string at check_rln_registration

1c901c7

fix: add gen_step_id function

9a36ac5

fix: RLN_CREDENTIALS as loaded from .env

da205bb

fix: RLN_CREDENTIALS example, skipping test if not set

25afac4

romanzac marked this pull request as ready for review February 9, 2024 06:58

romanzac requested a review from fbarbu15 February 12, 2024 07:22

fbarbu15 approved these changes Feb 12, 2024

View reviewed changes

romanzac added 14 commits February 12, 2024 15:43

test: RLN with actions

5235658

fix: tune up RLN timeouts for Github runners

0417a2e

test: filesystem write to /

a0184ac

fix: change RLN data to be stored at working directory

20c1649

fix: catch exception instead of "if not"

fa3b008

- print out container log

fix: wrap logs into debug msg

ace949a

fix: print log file

633e774

fix: remove additional logging

7c0acf8

fix: exit RLN cred parsing sooner when not used

65c4031

- delete proper keys from default_args

fix: Allure report

8932f41

fix: Discord notifications

5cd447a

fix: remove f-string

1fec5f6

Merge branch 'master' into chore-rln-relay-tests

a0b2921

fix: delete test workflow

fa5f71d

romanzac merged commit 8cb44f1 into master Feb 13, 2024
1 check passed

romanzac deleted the chore-rln-relay-tests branch February 13, 2024 14:01

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore: RLN registration support #16

chore: RLN registration support #16

romanzac commented Feb 5, 2024

fbarbu15 left a comment

romanzac commented Feb 13, 2024 •

edited

chore: RLN registration support #16

chore: RLN registration support #16

Conversation

romanzac commented Feb 5, 2024

PR Details

fbarbu15 left a comment

Choose a reason for hiding this comment

romanzac commented Feb 13, 2024 • edited

romanzac commented Feb 13, 2024 •

edited