Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixes for latest failures #19

Merged
merged 1 commit into from
Mar 5, 2024
Merged

fixes for latest failures #19

merged 1 commit into from
Mar 5, 2024

Conversation

fbarbu15
Copy link
Collaborator

@fbarbu15 fbarbu15 commented Mar 4, 2024 •
edited

PR Details

  • Use strict versions to prevent failures regarding lib setup and deviations across envs
  • Smart wait mechanism for filter messages

Issues reported:

@fbarbu15 fbarbu15 marked this pull request as ready for review March 4, 2024 16:55
@fbarbu15 fbarbu15 requested a review from romanzac March 4, 2024 16:57
romanzac
romanzac approved these changes Mar 5, 2024
View reviewed changes
Copy link
Collaborator

@romanzac romanzac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@fbarbu15 fbarbu15 merged commit 7df4741 into master Mar 5, 2024
2 checks passed
@fbarbu15 fbarbu15 deleted the chore/fix-failures branch March 5, 2024 06:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@romanzac romanzac romanzac approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@fbarbu15 @romanzac