Relay Publish: Extend coverage

[fbarbu15]

Second iteration of the framework for interop/e2e tests:

• finished relay publish coverage: 26 tests
• extend waku node api with more actions
• add common custom logger lib
• add more reusable functions/steps for relay tests
• improve setup/cleanup hooks
• discovered multiple bugs in the process

[AlbertoSoutullo]

I really like this! Just a comment that may or may not be helpful. Unless you specifically want to use discv5, I also think it is a good idea to connect nodes manually. It is an admin API method, so you have to enable it with --rpc-admin=true.
I guess depending on the test case, this may be more handy than have to wait for the discovery protocol connections. Also, you get a bool with the success or failure of the connection, that you can use to keep going with the test or assert the error. Just a comment, of course.

Cool work!

[fbarbu15]

I really like this! Just a comment that may or may not be helpful. Unless you specifically want to use discv5, I also think it is a good idea to connect nodes manually. It is an admin API method, so you have to enable it with --rpc-admin=true. I guess depending on the test case, this may be more handy than have to wait for the discovery protocol connections. Also, you get a bool with the success or failure of the connection, that you can use to keep going with the test or assert the error. Just a comment, of course.

Cool work!

Thanks for the feedback and the suggestion.
If it speeds up tests then I need to try it.
We could have dedicated tests for this connection method or have it behind a feature flag and enable/disable it for the whole suite. Need to think how it makes more sense, I tend to go with the 1st approach and have a dedicated suite for the Admin API. Either way it needs some representation for sure!

[AlejandroCabeza]

LGTM! Just added a few small suggestions/improvements that you can pay attention to if you feel like so 😄

[fbarbu15]

I really like this! Just a comment that may or may not be helpful. Unless you specifically want to use discv5, I also think it is a good idea to connect nodes manually. It is an admin API method, so you have to enable it with --rpc-admin=true. I guess depending on the test case, this may be more handy than have to wait for the discovery protocol connections. Also, you get a bool with the success or failure of the connection, that you can use to keep going with the test or assert the error. Just a comment, of course.

Cool work!

If it speeds up tests then I will

LGTM! Just added a few small suggestions/improvements that you can pay attention to if you feel like so 😄

Thanks for the suggestions Alex!
Implemented most of them

[AlbertoSoutullo]

Ok, I don't think I have anything else to add after that review.
You are in good hands with Python Alex's reviews.

[romanzac]

Florin, you are moving at great leaps forward. Thanks!

[fbarbu15]

Florin, you are moving at great leaps forward. Thanks!

Thanks @romanzac ! Usually it starts fast but when it's mature enough it slows down