small fixes #20
Merged
small fixes #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
romanzac
approved these changes
Mar 7, 2024
There was a problem hiding this comment.
LGTM!
Just curious, is there any story what makes you changing forth and back these calls?
forth:
7df4741
test_all_nodes_subscribed_to_the_topic(self):
-self.check_published_message_reaches_filter_peer()
+self.wait_for_published_message_to_reach_filter_peer()
back:
b49ef4a
test_all_nodes_subscribed_to_the_topic(self):
-self.wait_for_published_message_to_reach_filter_peer()
+self.check_published_message_reaches_filter_peer()
|
It was a mistake from my part. It seem to fix the flaky test but it didn't. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Details
Small fixes and adjustments for better debugging
Issues reported: