chore: RLN relay tests #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- temporarily use local docker images
- add spam and alternate rate tests
- prepare for non default settings for RLN
fbarbu15
reviewed
Apr 22, 2024
There was a problem hiding this comment.
Thanks! Added few comments
Also I would think of some additional e2e tests/checks like:
- check that peer actually receives the messages, not only that publish works
- node1 is RLN enabled, node2 is RLN disabled, what happens?
- node1 is has some flags values(like rln_relay_epoch_sec), node2 has other values, what happens?
- message is send via lightpush while RLN is enabled, does it work to bypass rln?
- extend timeout for ensure_ready() to 600s - add ensure_healthy() for future use - add text content based rest call - remove NODE1, NODE2 imports
- removed RLN test class inheritance from StepsRelay
- add grouping of tests to runner - use smaller dataset for spam rate tests
- remove current dir debug
- delete test workflow
…e-rln-relay-tests
|
I had problems to run tests in parallel, due to the same file path for the keystore, which might be possible to solve. In the time being however, I think there are other issues and number of tests isn't high, so I would keep them serialized. RLN tests were grouped @pytest.mark.xdist_group(name="RLN serial tests") and Pytest worker mode changed to --dist loadgroup |
|
"additional_nodes" variable override with nwaku nodes only was added to "Nim -> Nim Waku Interop Tests" workflow to accommodate multi node RLN tests. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Details
Batch of tests for Waku Relay with RLN enabled.
Changes
Tests available to run:
cd waku-interop-tests
pytest tests/relay/test_rln.py
Issues reported: