Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: go waku connection issues #33

Merged
merged 7 commits into from
Apr 23, 2024
Merged

Conversation

fbarbu15
Copy link
Collaborator

@fbarbu15 fbarbu15 commented Apr 22, 2024

PR Details

  • Added StepsCommon where functionality that applies to all tests/steps should be added
  • Refactored add peer to be more resilient and also work on go-waku. This seems to fix all random failures we seen between nim->go

Issues reported:

@fbarbu15 fbarbu15 changed the title Chore/go waku connection issues chore: go waku connection issues Apr 22, 2024
@fbarbu15 fbarbu15 marked this pull request as ready for review April 23, 2024 06:23
@fbarbu15 fbarbu15 requested a review from romanzac April 23, 2024 06:23
Copy link
Collaborator

@romanzac romanzac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Common for steps might come handy as each functionality to test have its own nuances. It is not always possible to share code across all of them.

@fbarbu15
Copy link
Collaborator Author

LGTM. Common for steps might come handy as each functionality to test have its own nuances. It is not always possible to share code across all of them.

Yes, I used this kind of structure in the past with specific steps and then common ones and it scales well if you make sure you don't change the common code too often(if you change it often you will break stuff where you don't expect)
So we need to put in common steps code that will remain the same.

@fbarbu15 fbarbu15 merged commit 69c8e3f into master Apr 23, 2024
3 checks passed
@fbarbu15 fbarbu15 deleted the chore/go-waku-connection-issues branch April 23, 2024 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants