Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Relay Publish: multiple nodes #4

Merged
merged 9 commits into from
Nov 21, 2023
Merged

Relay Publish: multiple nodes #4

merged 9 commits into from
Nov 21, 2023

Conversation

fbarbu15
Copy link
Collaborator

@fbarbu15 fbarbu15 commented Nov 17, 2023 •
edited

  • added support for multiple nodes via github inputs / env variable, and added dedicated tests that run with dynamic number of tests
  • decided to explicitly use (remove autouse=true) fixtures from inherited classes because this way it's much more clear what the tests are doing. Those fixtures can be called at class level or at test level depending on the need
  • post inputs values and report link in the github actions summary
    image

@fbarbu15 fbarbu15 changed the title Tests/relay publish 3 Tests/multiple nodes publish Nov 20, 2023
@fbarbu15 fbarbu15 changed the title Tests/multiple nodes publish Relay Publish: multiple nodes Nov 20, 2023
@fbarbu15 fbarbu15 marked this pull request as ready for review November 20, 2023 15:35
romanzac
romanzac approved these changes Nov 21, 2023
View reviewed changes
Copy link
Collaborator

@romanzac romanzac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@fbarbu15 fbarbu15 merged commit a6a0440 into master Nov 21, 2023
1 of 3 checks passed
@fbarbu15 fbarbu15 deleted the tests/relay-publish-3 branch November 21, 2023 07:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@romanzac romanzac romanzac approved these changes

@AlejandroCabeza AlejandroCabeza Awaiting requested review from AlejandroCabeza

@AlbertoSoutullo AlbertoSoutullo Awaiting requested review from AlbertoSoutullo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@fbarbu15 @romanzac