Test/peer connection management #45
Conversation
src/libs/common.py
Outdated
| @@ -38,3 +38,18 @@ def delay(num_seconds): | |||
|
|
|||
| def gen_step_id(): | |||
| return f"{datetime.now().strftime('%Y-%m-%d_%H-%M-%S')}__{str(uuid.uuid4())}" | |||
|
|
|||
|
|
|||
| def peer_info2id(peer, is_nwaku=True): | |||
There was a problem hiding this comment.
I think those methods should be part of the waku_node as they seem to be waku specific.
Here, the common.py file contains helper methods that are unrelated to waku
There was a problem hiding this comment.
Methods moved at 63d7c36
Let's have a discussion tomorrow about doing more in this PR. If I have time budget for that, it is interesting test topic to cover.
There was a problem hiding this comment.
If you have ideas for new interesting tests then it makes sense to keep this open and add new tests next week let's say.
But this week you should focus on Nomos as we discussed
There was a problem hiding this comment.
@fbarbu15 I've processed all remaining issues on my list, and I think we can close the PR. Please let me know what you think.
There was a problem hiding this comment.
LGTM except that I don't see any waiting.
From what I understand of nwaku peer management, peer info is going to be populated only after some time has passed (full connection cycle).
I'm afraid that without waiting for some unknown time (1s?) the tests will always fail.
src/env_vars.py
Outdated
| @@ -14,9 +14,10 @@ def get_env_var(var_name, default=None): | |||
|
|
|||
|
|
|||
| # Configuration constants. Need to be upercase to appear in reports | |||
| DEFAULT_NWAKU = "harbor.status.im/wakuorg/nwaku:latest" | |||
| # DEFAULT_NWAKU = "harbor.status.im/wakuorg/nwaku:latest" | |||
| DEFAULT_NWAKU = "wakuorg/nwaku:wakunode2-v0.28.0-peerdb" | |||
There was a problem hiding this comment.
please revert this change
Delays added at db5a76b |
PR Details
Tests to cover peer & connection management basic functionality and related known issues
Issues reported: