Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: refactor setup relay node for sharding #48

Merged
merged 3 commits into from
Jul 2, 2024

Conversation

romanzac
Copy link
Collaborator

@romanzac romanzac commented Jul 1, 2024

PR Details

Refactor setup first and second relay node functions to be reusable for sharding.

Test run report https://waku-org.github.io/waku-interop-tests/nim/258/

@romanzac romanzac marked this pull request as ready for review July 1, 2024 15:25
@romanzac romanzac requested a review from fbarbu15 July 1, 2024 15:25
Copy link
Collaborator

@fbarbu15 fbarbu15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.
Did you run the tests against this PR ?
If yes can you please update the description with report links?

@romanzac
Copy link
Collaborator Author

romanzac commented Jul 2, 2024

LGTM, thanks. Did you run the tests against this PR ? If yes can you please update the description with report links?

Yes, done. Thanks.

@romanzac romanzac merged commit 0ce2572 into master Jul 2, 2024
1 check passed
@romanzac romanzac deleted the chore-refactor-setup-first-second-relay-node branch July 2, 2024 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants