Filter Subscribe #6
Conversation
fbarbu15
requested review from
AlejandroCabeza,
AlbertoSoutullo and
romanzac
There was a problem hiding this comment.
LGTM.
Also, before I forget, regarding relay (and community messages, that I don't think you are doing right now), looks like they are facing message loss issues. This was commented in a call yesterday, and also in a comment today.
Maybe it gives you more ideas about test cases, maybe not. I simply wanted you to be aware of it, just in case..
src/node/api_clients/rpc.py
Outdated
| set_subscriptions_response = self.rpc_call( | ||
| "post_waku_v2_filter_v1_subscription", | ||
| [ | ||
| subscription["contentFilters"] if "contentFilters" in subscription else [], |
There was a problem hiding this comment.
These can be shorthanded to
subscription.get("contentFilters", [])
# and
subscription.get("pubsubTopic")There was a problem hiding this comment.
good point, it's more easy to read, thanks
src/steps/relay.py
Outdated
|
|
||
| @pytest.fixture(scope="function") | ||
| def relay_warm_up(self): | ||
| try: | ||
| self.wait_for_published_message_to_reach_peer() | ||
| self.wait_for_published_message_to_reach_relay_peer() | ||
| logger.info("WARM UP successful!!") | ||
| except Exception as ex: | ||
| raise TimeoutError(f"WARM UP FAILED WITH: {ex}") | ||
|
|
||
| # this method should be used only for the tests that use the warm_up fixture |
There was a problem hiding this comment.
You mean the relay_warm_up fixture?
|
|
||
| def test_filter_update_subscription_with_invalid_pubsub_topic_format(self, subscribe_main_nodes): | ||
| try: | ||
| self.update_filter_subscription({"requestId": "1", "contentFilters": [self.test_content_topic], "pubsubTopic": [self.test_pubsub_topic]}) |
There was a problem hiding this comment.
With "invalid pubsub topic form" we're talking about "type" or "string formatting"?
I mean: "list of strings" (which is what seems to happen) vs the "specified rfc string format"?
I don't know if I'm making sense 😅
There was a problem hiding this comment.
Yes, in this test I'm passing a list of strings instead of string. I will update the test name to be more suggestive
There was a problem hiding this comment.
LGTM.
waku-org/go-waku#928 shows how important interop tests are. I won't get to these kind of errors just by using Go functions from codebase.
encoding/hex: odd length hex string error when subscribing
pubsubTopic not required as described in the specs