fix: add meta field to WakuMessage, and ephemeral to RelayWakuMessage
#2
Conversation
| @@ -118,6 +118,9 @@ WakuMessage: | |||
| format: int64 | |||
| ephemeral: | |||
| type: boolean | |||
| meta: | |||
There was a problem hiding this comment.
How about rateLimitProof? According to https://rfc.vac.dev/spec/17/#wakumessage it can also be part of the message.
Also I saw that RPC protocol will return it, but REST does not
There was a problem hiding this comment.
To be honest, I'd like to return all the fields that are part of the wakumessage protobuffer, instead of just an specific subset
There was a problem hiding this comment.
I wonder if it's okay to do that?
cc: @NagyZoltanPeter what do you think if we return all fields available in the protobuffer?
There was a problem hiding this comment.
This won't be the quickest reply ever. Yes I do think we should mimic protobuf structures over REST API.
|
Should we merge this PR? But maybe without the ephemeral yet. I just added support for meta field in nwaku. But having ephemeral might break things, as we don't let users set it when sending messages via REST (we should allow it, right?) |
According to https://rfc.vac.dev/spec/14/, the
metafield is an optional application specific attribute, so it makes sense for devs to be able to specify this field when using relay. I also ended up addingephemeraltoRelayWakuMessageto not store the message.