Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Update to .Net 5.0 & ABP 4.0.0 #17

Merged
merged 8 commits into from
Nov 30, 2020
Merged

Conversation

enisn
Copy link
Contributor

@enisn enisn commented Nov 24, 2020

Summary

This PR includes mgiration to .Net 5.0 and update of all ABP packages to v4.0.0-rc.4.
Also breaking changes are implemented.

Solution

I think this solves automatically #15 and #16 compatibility problems.

@enisn
Copy link
Contributor Author

enisn commented Nov 24, 2020

Can you review @wakuflair ?

@wakuflair
Copy link
Owner

Great! @enisn

I will look at it ASAP.

@wakuflair
Copy link
Owner

wakuflair commented Nov 26, 2020

I have some compile errors, would you check them?

  FakeCurrentPrincipalAccessor.cs(12, 41): [CS0507] 'FakeCurrentPrincipalAccessor.GetClaimsPrincipal()': cannot change access modifiers when overriding 'protected' inherited member 'ThreadCurrentPrincipalAccessor.GetClaimsPrincipal()'
AdminLTEPro.Web
  AdminLTEProBrandingProvider.cs(1, 47): [CS0234] The type or namespace name 'Components' does not exist in the namespace 'Volo.Abp.AspNetCore.Mvc.UI.Theme.Shared' (are you missing an assembly reference?)
  AdminLTEProBrandingProvider.cs(7, 48): [CS0246] The type or namespace name 'DefaultBrandingProvider' could not be found (are you missing a using directive or an assembly reference?)
  AdminLTEProBrandingProvider.cs(9, 32): [CS0115] 'AdminLTEProBrandingProvider.AppName': no suitable method found to override

@enisn
Copy link
Contributor Author

enisn commented Nov 26, 2020

Sorry, I couldn't test on the test project before. Now I've fixed compile errors with commit dffcbc4.

@wakuflair
Copy link
Owner

I pulled your PR, however I still cannot run it successfully.(Maybe the sample application should be regenerated with ABP 4.0 CLI)

Would you try it in a clean folder(pull & run) ?

@wakuflair
Copy link
Owner

OK now, thanks!

@wakuflair wakuflair merged commit d7aba37 into wakuflair:master Nov 30, 2020
@wakuflair
Copy link
Owner

I will push the new theme package after ABP 4.0 final is released.

@enisn
Copy link
Contributor Author

enisn commented Dec 1, 2020

Thank you @wakuflair

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants