Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decompress1X panic crash #1

Closed
fdr opened this issue Jul 5, 2017 · 0 comments
Closed

Decompress1X panic crash #1

fdr opened this issue Jul 5, 2017 · 0 comments

Comments

@fdr
Copy link
Collaborator

fdr commented Jul 5, 2017

While fetching a backup (not a wal segment). Commit: 96e46ad

panic: Decompress1X

goroutine 14 [running]:
github.com/katie31/extract.Decompress(0x935060, 0xc42000e088, 0x9354e0, 0xc42029c200)
	/home/mapi/var/go/src/github.com/katie31/extract/lzo.go:96 +0x747
github.com/katie31/extract.ExtractAll.func1.1(0x934fa0, 0xc420015ca0, 0xc42000e088)
	/home/mapi/var/go/src/github.com/katie31/extract/decomex.go:66 +0xbf
created by github.com/katie31/extract.ExtractAll.func1
	/home/mapi/var/go/src/github.com/katie31/extract/decomex.go:68 +0x113
/home/mapi/lib/util.rb:4:in `r': unhandled exception
	from /home/mapi/lib/postgres_installer.rb:104:in `fetchdb'

Postscript:

I think these two branches should be swapped, i.e. an error should be printed before doing the output-length check. Typical Go convention the output of a multi-valued-return that includes an error may still allow an output result value to be returned in an undefined state.

https://github.com/katie31/extract/blob/96e46adc0722e20462be8e0e1ac96bd84f1792b5/lzo.go#L95-L100

PSPS:

I swapped the order and gave things another try:

...
base/13290/2605
base/13290/2610_vm
base/13290/2601_fsm
base/13290/2685
base/13290/2618
base/13290/3164
base/13290/3079
base/13290/13136
base/13290/3079_vm
base/13290/3118_vm
base/13290/1255_vm
panic: EOF
@katie31 katie31 closed this as completed Jul 28, 2017
usernamedt referenced this issue in usernamedt/wal-g Mar 26, 2020
KhurtinDN pushed a commit to KhurtinDN/wal-g that referenced this issue Jun 22, 2022
heinerstilz added a commit to ServiceNow/wal-g that referenced this issue Aug 19, 2022
* expose upgraded zstd compressor

* mention zstd in docs

* zstd 1.5.2 + patches

* remove unused lines in go.sum
x4m pushed a commit that referenced this issue Aug 29, 2022
* expose upgraded zstd compressor

* mention zstd in docs

* zstd 1.5.2 + patches

* remove unused lines in go.sum
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants