Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sort backups by the creation time in generic backup-list command #1108

Open
usernamedt opened this issue Oct 5, 2021 · 3 comments
Open

Sort backups by the creation time in generic backup-list command #1108

usernamedt opened this issue Oct 5, 2021 · 3 comments

Comments

@usernamedt
Copy link
Member

Thanks to this PR, WAL-G for Postgres sorts the backups in the output of the backup-list command by the creation time. However, it does that only when being called with the --detail flag.

It happens because WAL-G uses two different backup-list handlers:

  1. Generic (same for all databases) when it is launched without the --detailed flag (source code)
  2. Postgres-specific when being launched with the --detail flag (source code)

I think that WAL-G generic backup list handler should utilize the GenericMetadata to sort the backups by the creation time. For some databases, the appropriate adapters are already written: MySQL, Postgres, Greenplum. As for FDB, Redis, and SQLServer which also use the generic backup-list command handler currently there is no GenericMetadata adapter implemented.

So, I can see the following plan to implement this feature:

  1. Implement the GenericMetaFetcher for FDB, Redis, and SQLServer.
  2. Fetch the GenericMetadata in the backup-list command handler to sort the backup-list output by the creation time.
@OlleLarsson
Copy link

Hello @usernamedt, is this issue prioritized anywhere on your roadmap 😄 ?

@x4m
Copy link
Collaborator

x4m commented May 10, 2024

There's a big chance that we need to recruit some other principal author for the feature.
Maybe @debebantur knows anyone, but anyway PR would be welcomed.

@debebantur
Copy link
Contributor

debebantur commented May 16, 2024

Hello, we will try to find someone for this feature. If someone starts to implement it, I will write about it here. But any PR would be welcomed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants