Add sorting by creation time when --detailed flag is not specified. #1405
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tewboat
requested review from
perekalov,
VGoshev,
KhurtinDN,
mialinx,
ostinru,
teem0n and
a team
as code owners
tewboat
changed the title
usernamedt
requested changes
Jan 23, 2023
internal/BackupTimeWithMetadata.go
Outdated
| @@ -0,0 +1,8 @@ | |||
| package internal | |||
There was a problem hiding this comment.
well, separate file for one struct is an overkill, I suggest to move it to internal/backup_list_handler.go
internal/backup_util.go
Outdated
| @@ -113,6 +140,27 @@ func SortBackupTimeSlices(backupTimes []BackupTime) { | |||
| }) | |||
| } | |||
|
|
|||
| func SortBackupTimeWithMetadataSlices(backupTimes []BackupTimeWithMetadata) { | |||
| order := ByCreationTime | |||
There was a problem hiding this comment.
Well, if we always sort by the creation time why separate if down below? I suggest to remove it
tewboat
force-pushed
the
issue/1108
branch
2 times, most recently
from
f2b9f7f
to
eb3cf84
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request description
[Issue] (#1108)
Added GenericMetaInteractors for:
Interactors are used for fetching backup StartTime to sort backups by creation time.
Added sorting by creation time in DefaultHandleBackupList when
--detailedflag is not specified.