Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Metrics are not pushed on upload failures because of Fatal logging #1422

Open
francoispqt opened this issue Jan 26, 2023 · 0 comments · Fixed by #1423
Open

Metrics are not pushed on upload failures because of Fatal logging #1422

francoispqt opened this issue Jan 26, 2023 · 0 comments · Fixed by #1423

Comments

@francoispqt
Copy link
Contributor

Database name

All of them

Issue description

The metrics feature implemented here does not work properly on upload failures because the pushMetrics happens in the cobra post run hook which is not called because we ErrorLogger.Fatal when we encounter an error.
@francoispqt francoispqt changed the title Metrics are not pushed on most failures because of Fatal logging Metrics are not pushed on upload failures because of Fatal logging Jan 26, 2023
@francoispqt francoispqt mentioned this issue Jan 26, 2023
Merged
@usernamedt usernamedt reopened this Mar 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@francoispqt @usernamedt