adding push metrics as a defer in the upload method to make sure metrics are pushed even on failure #1423
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ics are pushed even on failure
usernamedt
approved these changes
Mar 3, 2023
|
Somehow I missed this PR. Ok, let's merge it as a temporary solution. But we need to solve the root cause eventually - handle fatal errors gracefully. Thanks for your contribution! |
|
Yes I agree, my take would be to stop using log.Fatal and bubble up errors but that's way more work |
usernamedt
added a commit
that referenced
this pull request
Mar 9, 2023
Merged
usernamedt
added a commit
that referenced
this pull request
Mar 9, 2023
|
Any plans to fix it? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Database name
All of them
Pull request description
The metrics feature works fine to record uploads when they are successful but metrics are never pushed when an upload fails because Fatal logging exits directly and prevents the
PostRuncobra hook from running.To solve that I propose to call
PushMetricsdirectly from theuploader.Uploadmethod.Describe what this PR fix
It fixes #1422