Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AWS_REGION should be optional #6

Closed
willglynn opened this issue Aug 18, 2017 · 2 comments
Closed

AWS_REGION should be optional #6

willglynn opened this issue Aug 18, 2017 · 2 comments

Comments

@willglynn
Copy link
Contributor

Right now, the user has to specify WALE_S3_PREFIX and AWS_REGION. However, WALE_S3_PREFIX indicates an S3 bucket, S3 buckets have globally unique names, and the s3:GetBucketLocation API can take a S3 bucket name and return its region. AWS_REGION should therefore be optional, with wal-g able to determine the bucket's region automatically.

@fdr
Copy link
Collaborator

fdr commented Aug 18, 2017

Unfortunately, it's not optional in every region, and new regions will make it less and less optional, on account of SigV4. GetBucketLocation is not always granted via IAM and I'm not too keen to expend extra API round-trips for this.

@fdr fdr closed this as completed Aug 18, 2017
@willglynn
Copy link
Contributor Author

I didn't say wal-g should disregard AWS_REGION, I suggested it should fall back to calling s3:GetBucketLocation if AWS_REGION were unspecified. Paired with #5, this would allow wal-g to run knowing only WALE_S3_PREFIX, with implicit defaults functioning for all the other parameters.

Would you accept a PR to this effect?

usernamedt referenced this issue in usernamedt/wal-g Mar 24, 2020
usernamedt referenced this issue in usernamedt/wal-g Mar 24, 2020
usernamedt referenced this issue in usernamedt/wal-g Mar 24, 2020
KhurtinDN pushed a commit to KhurtinDN/wal-g that referenced this issue Jun 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants