-
Notifications
You must be signed in to change notification settings - Fork 432
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AWS_REGION should be optional #6
Comments
Unfortunately, it's not optional in every region, and new regions will make it less and less optional, on account of SigV4. GetBucketLocation is not always granted via IAM and I'm not too keen to expend extra API round-trips for this. |
I didn't say Would you accept a PR to this effect? |
Right now, the user has to specify
WALE_S3_PREFIX
andAWS_REGION
. However,WALE_S3_PREFIX
indicates an S3 bucket, S3 buckets have globally unique names, and thes3:GetBucketLocation
API can take a S3 bucket name and return its region.AWS_REGION
should therefore be optional, withwal-g
able to determine the bucket's region automatically.The text was updated successfully, but these errors were encountered: