New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add s3 download by range #1083
Merged
Merged
Add s3 download by range #1083
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
proggga
force-pushed
the
make_s3_download_by_range
branch
13 times, most recently
from
September 8, 2021 14:08
a21a01c
to
a3ec48d
Compare
usernamedt
requested changes
Sep 9, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, can you please add an integration test with S3_RANGE_BATCH_ENABLED
turned on?
proggga
force-pushed
the
make_s3_download_by_range
branch
from
September 13, 2021 09:43
b88b993
to
5646f61
Compare
proggga
force-pushed
the
make_s3_download_by_range
branch
from
September 13, 2021 16:15
3a293c2
to
ca4ed5e
Compare
usernamedt
reviewed
Sep 14, 2021
usernamedt
reviewed
Sep 14, 2021
docker/mysql_tests/scripts/base_tests/full_xtrabackup_test_with_ranges.sh
Outdated
Show resolved
Hide resolved
proggga
force-pushed
the
make_s3_download_by_range
branch
from
September 14, 2021 10:07
2b32c61
to
2a24b21
Compare
proggga
force-pushed
the
make_s3_download_by_range
branch
from
September 15, 2021 15:10
2a24b21
to
2d0d0a6
Compare
proggga
force-pushed
the
make_s3_download_by_range
branch
from
September 15, 2021 17:46
2d0d0a6
to
8f588c5
Compare
proggga
force-pushed
the
make_s3_download_by_range
branch
from
September 16, 2021 11:48
c40729a
to
81c5113
Compare
usernamedt
approved these changes
Sep 16, 2021
perekalov
pushed a commit
to perekalov/wal-g
that referenced
this pull request
Jan 12, 2022
* Add s3 download by range * Add config add devel * Full remake * Small fixes * Retrigger * Fix exp backoff for s3reader * Simplified debug log for s3Reader * Extract s3reader * go fmt changes * Removed debug line * Reuse last Body * Fix config, add test for mysql with ranges * Small rename * Add comment, fix test, fix error msg * Rename bucket * Add devel, fix prefix for mysql test * Fix docs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Debug s3 storage download by ranges