Support multiple s3 storage configuration #1183
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After merging wal-g/storages#45 we are unable to configure multiple s3 storages as it needed in copy commands. Suggested fix wal-g#1050 works, but it's dirty. Call to the `FolderFromConfig` pollutes the environment, making impposible to any configuration function (like `ConfigureCompressor`) after it. Solution: * Wal-g config file should be the first priorty configuration source. * Set AWS_ACCESS_KEY_ID and AWS_SECRET_ACCESS_KEY only if they are not empty, otherwise fallback to the enviroment (and other storage dependent) configuration defaults * Do not overwrite the environment in `FolderFromConfig`
|
@rocket357, @andersosthus, you may be interested/affected by these changes |
|
Also update |
usernamedt
approved these changes
Dec 19, 2021
|
@paalkr just a heads up about this change |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After merging wal-g/storages#45 we are unable to configure multiple s3 storages as it needed in copy commands.
Suggested fix #1050 works, but it's dirty. Call to the
FolderFromConfigpollutes the environment, making impposible to any configuration function (likeConfigureCompressor) after it.Solution:
FolderFromConfig