Add daemon mode for wal-push command #1353
Conversation
rogaliiik
force-pushed
the
daemon-master-dev
branch
4 times, most recently
from
a9f7e95
to
66c110d
Compare
rogaliiik
force-pushed
the
daemon-master-dev
branch
14 times, most recently
from
af155a8
to
912cf6a
Compare
rogaliiik
force-pushed
the
daemon-master-dev
branch
from
912cf6a
to
766a6e2
Compare
| else | ||
| echo "Error in WAL-G response" | ||
| exit 1 | ||
| fi |
There was a problem hiding this comment.
We also need to check that WAL has been archived correctly.
|
|
||
| // daemonCmd represents the daemon archive command | ||
| var daemonCmd = &cobra.Command{ | ||
| Use: "daemon daemon_socket_path", |
There was a problem hiding this comment.
Add some information about this command to the documentation.
| func (h *ArchiveMessageHandler) Handle(messageBody []byte) error { | ||
| err := messageValidation(messageBody) | ||
| if err != nil { | ||
| tracelog.ErrorLogger.Printf("Incorrect message: %v\n", err) |
There was a problem hiding this comment.
You can just log the error in the upper level.
Here you can use the fmt.Errorf("msg: %w", err) to wrap error with some message.
For example:
if err != nil {
return fmt.Errorf("message validation failed: %w", err)
}There was a problem hiding this comment.
Same issue in other places below.
| tracelog.ErrorLogger.Fatal("Error on listening socket:", err) | ||
| } | ||
| for { | ||
| fd, err := l.Accept() |
There was a problem hiding this comment.
What if we would want to terminate the running daemon?
I suggest to add the signal listener and listend for SIGTERM to perform a graceful shutdown. But looks like it is a feature for the next PR, not for the MVP.
| messageType, messageBody, err := messageReader.Next() | ||
| if err != nil { | ||
| tracelog.ErrorLogger.Printf("Failed to read message from client %s, err: %v\n", c.RemoteAddr(), err) | ||
| _, _ = c.Write([]byte{'E'}) |
There was a problem hiding this comment.
do not ignore the possible errors
| messageHandler := GetMessageHandler(messageType, c, uploader) | ||
| if messageHandler == nil { | ||
| tracelog.ErrorLogger.Printf("Unexpected message type: %s", string(messageType)) | ||
| _, _ = c.Write([]byte{'E'}) |
There was a problem hiding this comment.
Create these mesage types as well:
type ErrorType SocketMessageType = 'E'
type ... SocketMessageType = 'F'
type ... SocketMessageType = 'O'
...
| } | ||
|
|
||
| func messageValidation(messageBody []byte) error { | ||
| if len(messageBody) < 24 { |
There was a problem hiding this comment.
Also, we archive not only WALs but other files with length other than 24.
I think we can remove this validation.
…tion; test listing.
rogaliiik
force-pushed
the
daemon-master-dev
branch
from
8a191d3
to
6fedfec
Compare
usernamedt
changed the title
Database name
postgresql15
Pull request description
Added daemon command for archiving wal segments