[Greenplum] do not fail backup on increment reading error #1365
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
usernamedt
force-pushed
the
do-not-fail-backup-on-increment-reading-error
branch
from
936f00c
to
7fdf179
Compare
usernamedt
force-pushed
the
do-not-fail-backup-on-increment-reading-error
branch
from
7fdf179
to
bd9ecdc
Compare
reshke
approved these changes
Oct 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, WAL-G will fail the entire backup process if it can't take an increment from AO/AOCS file. I propose to alter this logic to gracefully handle such cases and perform a regular upload instead.