Use pure go implementation for zstd #1376
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The first commit (regarding the NO_LIBBROTLI option in Makefile) and the go mod tidy action may be picked separately. The actual code change is all contained in the last commit: eff9c38 |
serprex
reviewed
Nov 11, 2022
usernamedt
previously requested changes
Nov 12, 2022
use github.com/klauspost/compress/zstd package for zstd compression and decompression remove github.com/Datadog/zstd
LeGEC
force-pushed
the
586-zstd-pure-go
branch
from
eff9c38
to
fe7972c
Compare
serprex
approved these changes
Nov 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Database name
All -- this PR modifies internal/compression/zstd
Pull request description
Use pure go implementation of zstd compressor/decompressor, from github.com/klauspost/compress module.
Importing current version : v1.15.12
fixes issue #586