Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add unit tests for the WriteBackupListDetails function #1395

Merged
merged 1 commit into from
Dec 5, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 1 addition & 2 deletions internal/databases/redis/backup_list_handler.go
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,6 @@ func GetBackupDetails(folder storage.Folder, backupTime internal.BackupTime) (ar
return metaData, nil
}

// TODO : unit tests
func writeBackupListDetails(backupDetails []archive.Backup, output io.Writer) error {
writer := tabwriter.NewWriter(output, 0, 0, 1, ' ', 0)
defer func() { _ = writer.Flush() }()
Expand All @@ -80,7 +79,7 @@ func writeBackupListDetails(backupDetails []archive.Backup, output io.Writer) er
return nil
}

//TODO : unit tests
// TODO : unit tests
func writePrettyBackupListDetails(backupDetails []archive.Backup, output io.Writer) {
writer := table.NewWriter()
writer.SetOutputMirror(output)
Expand Down
73 changes: 73 additions & 0 deletions internal/databases/redis/backup_list_handler_test.go
Original file line number Diff line number Diff line change
@@ -0,0 +1,73 @@
package redis

import (
"bytes"
"github.com/stretchr/testify/assert"
"github.com/wal-g/wal-g/internal/databases/redis/archive"
"testing"
)

var emptyColumnsBackups = []archive.Backup{
{
BackupName: "backupName",
},
{
UserData: "userData",
},
}

var shortValuesBackups = []archive.Backup{
{
BackupName: "b1",
UserData: "u1",
},
{
BackupName: "b2",
UserData: "u2",
},
}

var longValuesBackups = []archive.Backup{
{
BackupName: "veryLongBackupName1",
UserData: "someLongUsefulUserData1",
},
{
BackupName: "veryLongBackupName2",
UserData: "someLongUsefulUserData2",
},
}

func TestWriteBackupListDetails_NoBackups(t *testing.T) {
expectedOutput := "name start_time finish_time user_data data_size backup_size permanent\n"
buffer := bytes.Buffer{}
writeBackupListDetails(make([]archive.Backup, 0), &buffer)
assert.Equal(t, expectedOutput, buffer.String())
}

func TestWriteBackupListDetails_EmptyColumnsValues(t *testing.T) {
expectedOutput := "name start_time finish_time user_data data_size backup_size permanent\n" +
"backupName 0001-01-01T00:00:00Z 0001-01-01T00:00:00Z <nil> 0 0 false\n" +
" 0001-01-01T00:00:00Z 0001-01-01T00:00:00Z userData 0 0 false\n"
buffer := bytes.Buffer{}
writeBackupListDetails(emptyColumnsBackups, &buffer)
assert.Equal(t, expectedOutput, buffer.String())
}

func TestWriteBackupListDetails_ShortColumnsValues(t *testing.T) {
expectedOutput := "name start_time finish_time user_data data_size backup_size permanent\n" +
"b1 0001-01-01T00:00:00Z 0001-01-01T00:00:00Z u1 0 0 false\n" +
"b2 0001-01-01T00:00:00Z 0001-01-01T00:00:00Z u2 0 0 false\n"
buffer := bytes.Buffer{}
writeBackupListDetails(shortValuesBackups, &buffer)
assert.Equal(t, expectedOutput, buffer.String())
}

func TestWriteBackupListDetails_LongColumnsValues(t *testing.T) {
expectedOutput := "name start_time finish_time user_data data_size backup_size permanent\n" +
"veryLongBackupName1 0001-01-01T00:00:00Z 0001-01-01T00:00:00Z someLongUsefulUserData1 0 0 false\n" +
"veryLongBackupName2 0001-01-01T00:00:00Z 0001-01-01T00:00:00Z someLongUsefulUserData2 0 0 false\n"
buffer := bytes.Buffer{}
writeBackupListDetails(longValuesBackups, &buffer)
assert.Equal(t, expectedOutput, buffer.String())
}