Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add restore-point-list command for gp #1397

Merged
merged 2 commits into from Dec 20, 2022

Conversation

rogaliiik
Copy link
Contributor

Greenplum

Add restore-point-list command for Greenplum

@rogaliiik rogaliiik requested a review from a team as a code owner December 8, 2022 18:28
@rogaliiik
Copy link
Contributor Author

The functionality of this command is very similar to "backup-list" command. Should i write unittests for these functions?

utility/utility.go Outdated Show resolved Hide resolved
internal/restore_point_list_handler.go Outdated Show resolved Hide resolved
cmd/gp/restore_point_list.go Show resolved Hide resolved
utility/utility.go Outdated Show resolved Hide resolved
@usernamedt
Copy link
Member

usernamedt commented Dec 9, 2022

The functionality of this command is very similar to "backup-list" command. Should i write unittests for these functions?

A couple of unit tests checking that the command works as expected will be enough

@usernamedt usernamedt merged commit e5bb11f into wal-g:master Dec 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants