Print storage names in backup-list
#1538
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rdjjke
requested review from
perekalov,
VGoshev,
KhurtinDN,
mialinx,
ostinru,
teem0n and
a team
as code owners
rdjjke
force-pushed
the
backup-list-failover-storages/0
branch
4 times, most recently
from
184bdc7
to
0d85126
Compare
usernamedt
requested changes
Sep 1, 2023
If we create a folder with path "/" (representing the root folder), or with any other path starting with "/", the listing breaks: it finds no files or subfolders because their paths don't start with "/". Also stop creating multi-storage folders with path "/", and always represent the root path by "" to avoid ambiguity.
rdjjke
force-pushed
the
backup-list-failover-storages/0
branch
from
c80e33f
to
bbfd397
Compare
rdjjke
force-pushed
the
backup-list-failover-storages/0
branch
from
7ae632d
to
dde183c
Compare
rdjjke
force-pushed
the
backup-list-failover-storages/0
branch
from
dde183c
to
1b36239
Compare
usernamedt
approved these changes
Sep 4, 2023
teem0n
approved these changes
Sep 4, 2023
KhurtinDN
approved these changes
Sep 5, 2023
rdjjke
force-pushed
the
backup-list-failover-storages/0
branch
from
4a97ed2
to
ed7845b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PostgreSQL now supports failover storages which are used when the main one is dead.
In this PR I supported failover storages in
backup-listcommand: storage names are now printed along with the rest of the info.Storage names are also printed for all other databases besides PG, but only in the "basic" mode when
--detailflag isn't set.