Delete target backup (improvements) #917
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
usernamedt
force-pushed
the
delete-target-delta
branch
5 times, most recently
from
0aeea46
to
72a2de4
Compare
usernamedt
force-pushed
the
delete-target-delta
branch
from
72a2de4
to
82c2e10
Compare
usernamedt
force-pushed
the
delete-target-delta
branch
from
b04a4dd
to
bd352c5
Compare
usernamedt
force-pushed
the
delete-target-delta
branch
from
bd352c5
to
8465004
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR I propose several improvements to the previously introduced (#913) delete target backup command.
Rename the
--find-fullflag toFIND_FULLto match the other delete commands.Implement delta backups deletion. If delta backup is provided as the target, WAL-G will also delete all the dependant delta backups. Behaviour of the previously introduced
FIND_FULLis preserved. IfFIND_FULLis specified, WAL-G will delete all backups with the same base backup as the target.Examples:
target base_0000000100000000000000C9delete the base backup and all dependant delta backupstarget base_0000000100000000000000C9_D_0000000100000000000000C4delete delta backup and all dependant delta backupstarget FIND_FULL base_0000000100000000000000C9_D_0000000100000000000000C4delete delta backup and all delta backups with the same base backup