Fix crash in JS CG construction for malformed calls to new Function #1243
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liblit
approved these changes
Feb 23, 2023
MadhuNimmo
pushed a commit
to MadhuNimmo/WALA
that referenced
this pull request
Jul 10, 2023
…ala#1243) Our code for handling `new Function(...)` calls tries to parse and analyze the body argument to the call if it is a string constant. But, when that argument is malformed, previously we would crash. This PR adds a null check to make WALA's behavior more robust for that case.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our code for handling
new Function(...)calls tries to parse and analyze the body argument to the call if it is a string constant. But, when that argument is malformed, previously we would crash. This PR adds a null check to make WALA's behavior more robust for that case.