Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

get rid of HashCodeComparator and all its usages #134

Merged

Conversation

mohrm
Copy link
Contributor

@mohrm mohrm commented Jan 26, 2017

This addresses both #133 and #88

@msridhar
Copy link
Member

So the HashCodeComparator cods is really old and I can't tell from version control history why it was introduced. I'm guessing that at some point, module entries were being returned in a non-deterministic order, and this was an attempt to iterate through them deterministically. But I agree that it's not the right way to do it, at least not anymore. Seems like Julian is also OK with this change, so merging. Thanks for finding this!

@msridhar msridhar merged commit 71b505c into wala:master Jan 26, 2017
@mohrm mohrm deleted the pull-request__getridofhashcodecomparator branch January 31, 2017 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants