Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add and use version catalog updater #1402

Merged
merged 2 commits into from
May 27, 2024

Conversation

liblit
Copy link
Contributor

@liblit liblit commented May 27, 2024

Add a dependency catalog updater plugin

This plugin will help us clean and update the shared version catalog in gradle/libs.versions.toml. It does not run automatically. Instead, it provides a few helpful housekeeping tasks in the version catalog update group that we can run manually whenever convenient.

Update many dependencies

These updates were all discovered and applied using the versionCatalogUpdate task provided by the nl.littlerobots.version-catalog-update plugin.

For now, I'm considering only those upgrades that cause no test regressions and that require no changes to WALA's Java code. There are a few additional update opportunities that currently cause regressions. We can consider those separately, along with any Java code changes needed to make them work correctly.

[This
plugin](https://github.com/littlerobots/version-catalog-update-plugin)
will help us clean and update the shared version catalog in
`gradle/libs.versions.toml`.  It does not run automatically.  Instead,
it provides a few helpful housekeeping tasks in the `version catalog
update` group that we can run manually whenever convenient.
These updates were all discovered and applied using the
`versionCatalogUpdate` task provided by the
`nl.littlerobots.version-catalog-update` plugin.

For now, I'm considering only those upgrades that cause no test
regressions and that require no changes to WALA's Java code.  There are
a few additional update opportunities that currently cause regressions.
We can consider those separately, along with any Java code changes
needed to make them work correctly.
@liblit liblit added enhancement gradle WALA’s Gradle build system dependencies Pull requests that update a dependency file labels May 27, 2024
@liblit liblit self-assigned this May 27, 2024
@liblit liblit enabled auto-merge (rebase) May 27, 2024 21:55
Copy link
Member

@msridhar msridhar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

Copy link

Test Results

  577 files  ±0    577 suites  ±0   3h 3m 37s ⏱️ + 15m 13s
  735 tests ±0    718 ✅ ±0  17 💤 ±0  0 ❌ ±0 
3 559 runs  ±0  3 472 ✅ ±0  87 💤 ±0  0 ❌ ±0 

Results for commit e84f84a. ± Comparison against base commit d4a36ae.

@liblit liblit merged commit a001555 into wala:master May 27, 2024
11 checks passed
@liblit liblit deleted the add-and-use-version-catalog-updater branch May 27, 2024 22:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file enhancement gradle WALA’s Gradle build system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants