Add test for default and unknown/unsupported command

waldbaer · Jan 27, 2023 · af2684f · af2684f
1 parent 252e622
commit af2684f
Show file tree

Hide file tree

Showing 2 changed files with 24 additions and 0 deletions.
diff --git a/nodes/persistent-value.js b/nodes/persistent-value.js
@@ -243,6 +243,11 @@ module.exports = function(RED) {
 
         currentValue = inputValue;
       }
+      // -- Command: unknown / unsupported --
+      else {
+        node.error(`Unknown or unsupported persistent value command '${node.command}' used!`);
+        return null;
+      }
 
       // -- BlockIf --
       const blockFlow = checkBlockIfCondition(node, currentValue);

diff --git a/test/persistent_values_spec.js b/test/persistent_values_spec.js
@@ -244,6 +244,7 @@ describe('persistent value node', function() {
   it('should read the default value - string', function(done) {
     const flow = structuredClone(FlowNodeAllVariants);
     flow[0].value = ConfigValueString;
+    flow[0].command = undefined; // Extra test variant: Force usage of default command (read)
 
     helper.load([configNode, valueNode], flow, function() {
       const c = helper.getNode(NodeIdConfig);
@@ -970,4 +971,22 @@ describe('persistent value node', function() {
       v.receive({payload: AnyInputString});
     });
   });
+
+  // ==== Other / Error Handling Tests ========================================
+
+  it('should reject unknown / unsupported commands', function(done) {
+    const flow = structuredClone(FlowNodeAllVariants);
+    const unsupportedCommand = 'unsupported command';
+    flow[0].command = unsupportedCommand;
+
+    helper.load([configNode, valueNode], flow, function() {
+      const v = helper.getNode(NodeIdPersistentValue);
+
+      v.receive({payload: AnyInputString});
+
+      v.error.should.be.calledWithMatch(`Unknown or unsupported persistent value command '${unsupportedCommand}' used!`);
+      v.send.should.have.callCount(0);
+      done();
+    });
+  });
 });