Skip to content
This repository has been archived by the owner on Sep 20, 2019. It is now read-only.

PTY support #5

Merged
merged 7 commits into from Oct 15, 2012
Merged

PTY support #5

merged 7 commits into from Oct 15, 2012

Conversation

quark-zju
Copy link
Contributor

Add PTY support so that 'rails console', etc. works.

Other changes/improvements:

  • forward server process exitcode to client.
  • 'rails server' can be immediately stop by ^C now.
  • ^C in server stops all background process.
  • time usage moved from client to server to provide consistant output as non-rrails commands.
  • rrails --help
  • remove 'problem' in README, add shell rc tips

I think I have done some non-trivial work, thus I add one 'copyright' line.

* server report exit status to client.
* client help (remove env option, add host option).
* client Ctrl+C now kills server process immediately.
Conflicts:
	lib/rrails/server.rb
@quark-zju
Copy link
Contributor Author

This should be closed if #6 is merged.

walf443 added a commit that referenced this pull request Oct 15, 2012
- I want to use "-h" to --help. --host is minor option.
- I need -E option for other environment's task running.
@walf443 walf443 merged commit b12acb0 into walf443:master Oct 15, 2012
@walf443
Copy link
Owner

walf443 commented Oct 15, 2012

cool! geate work!

But I'd like not to change imcompatible. So, some patches should be more separate.

For example, I use -E option. so it don't want to remove.

@walf443
Copy link
Owner

walf443 commented Oct 15, 2012

I have no more time to read your patch today. I'm release it as v0.4.0 and I'm sorry to read #6 at later.

@quark-zju
Copy link
Contributor Author

I am sorry that I did not mention '-E' was reintroduced in #6 :/

Changes after merging this may cause conflict when merging #6. If it is not easy to solve, you can close #6, then I can merge back changes and open a new pull request.

@quark-zju quark-zju mentioned this pull request Oct 15, 2012
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants