Final spanish #1
Conversation
✅ Deploy Preview for phpscraper-de ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
| @@ -25,7 +25,7 @@ Este proyecto está patrocinado por: | |||
|
|
|||
| <a href="https://bringyourownideas.com" target="_blank" rel="noopener noreferrer"><img src="https://bringyourownideas.com/images/byoi-logo.jpg" height="100px"></a> | |||
|
|
|||
| ¿Quieres patrocinar este proyecto? [Póngase en contacto conmigo](https://peterthaleikis.com/contact). | |||
| ¿Quieres patrocinar este proyecto? [Escríbeme](https://peterthaleikis.com/contact). | |||
There was a problem hiding this comment.
"Escríbeme" or "Escríbe me" @walirazzaq ?
There was a problem hiding this comment.
I'll check it again. I think Deepl might have combined it 🤦🏼I'll try to cross verify it on some other translation services as well 👍🏼
websites/es/examples/headings.md
Outdated
| @@ -21,12 +21,12 @@ $web = new \spekulatius\phpscraper(); | |||
| /** | |||
| * Navegue hasta la página de pruebas. Contiene: | |||
| * | |||
| * <title>¡Estamos probando aquí!</title> | |||
There was a problem hiding this comment.
These are fixed in the test pages and we can't translate them, can you double check we are good with German too for this?
There was a problem hiding this comment.
Oh yes, I think we would need to revert them for de as well. I would do it first as we are having de version live as well
There was a problem hiding this comment.
It's alright - just fix it for DE and ES here. It isn't a big problem
There was a problem hiding this comment.
I've found some more places like this, have a look at the comments :)
There was a problem hiding this comment.
Onto that
I have understood it and will fix them all, together 👍🏼
| * ] | ||
| * | ||
| * @Note: | ||
| * Double because it's twice the same image: |
There was a problem hiding this comment.
We can translate these notes tho :)
| @@ -23,23 +23,22 @@ $web->go('https://test-pages.phpscraper.de/meta/lorem-ipsum.html'); | |||
| * <title>Lorem Ipsum</title> | |||
| */ | |||
|
|
|||
| // Obtener el título. Esto debería devolver: | |||
| // "Lorem Ipsum" | |||
| // Fetch the title. This will return: "Lorem Ipsum" | |||
There was a problem hiding this comment.
Looks like we undid the comment translation here
| /** | ||
| * $content ahora contiene: | ||
| * | ||
| * [ |
There was a problem hiding this comment.
Can you replace this print out with the English version in DE/ES?
There was a problem hiding this comment.
Yes, I am also looking for all such places where we need to use English only 👍🏼
websites/es/examples/headings.md
Outdated
| @@ -21,12 +21,12 @@ $web = new \spekulatius\phpscraper(); | |||
| /** | |||
| * Navegue hasta la página de pruebas. Contiene: | |||
| * | |||
| * <title>¡Estamos probando aquí!</title> | |||
There was a problem hiding this comment.
It's alright - just fix it for DE and ES here. It isn't a big problem
| ```php | ||
| $web = new \spekulatius\phpscraper(); | ||
|
|
||
| /** |
websites/es/examples/outline.md
Outdated
| /** | ||
| * $content ahora contiene: | ||
| * | ||
| * [ |
websites/es/examples/scrape-links.md
Outdated
| /** | ||
| * Navegue hasta la página de prueba. Contiene 6 enlaces a placekitten.com con diferentes atributos: | ||
| * | ||
| * <h2>Diferentes formas de envolver los atributos</h2> |
There was a problem hiding this comment.
Let's use the English for this part too until the next $web command
websites/es/examples/scrape-links.md
Outdated
| $web->go('https://test-pages.phpscraper.de/links/target.html'); | ||
|
|
||
| // Imprime el número de enlaces. | ||
| echo "This page contains " . count($web->links) . " links.\n\n"; |
There was a problem hiding this comment.
Let's use "Esta página contiene X enlaces." from below
websites/es/examples/scrape-links.md
Outdated
| /** | ||
| * Navegue hasta la página de prueba. Esta página contiene varios enlaces con diferentes atributos rel. Para ahorrar espacio sólo el primero: | ||
| * | ||
| * <a href="https://placekitten.com/432/287" rel="nofollow">gatito externo</a> |
websites/es/examples/scrape-links.md
Outdated
| * | ||
| * [ | ||
| * 'url' => 'https://placekitten.com/432/287', | ||
| * 'text' => 'gatito externo', |
There was a problem hiding this comment.
The text won't change, the rest is fine
| /** | ||
| * Navega hasta la página de la prueba. Contiene: | ||
| * | ||
| * <title>Gato & ratón</title> |
There was a problem hiding this comment.
I don't think this is correct too
| */ | ||
| $web->go('https://test-pages.phpscraper.de/meta/html-entities.html'); | ||
|
|
||
| // Imprime el título: "Gato & Ratón" |
There was a problem hiding this comment.
I don't think this is correct too
| ``` | ||
|
|
||
| ::: tip CONSEJO | ||
| Se han tenido en cuenta las entidades y los caracteres especiales en toda la biblioteca. Si encuentra un lugar donde no funcionan como se espera, por favor, plantee un [problema].(https://github.com/spekulatius/PHPScraper/issues). |
There was a problem hiding this comment.
looks like the dot should be after only
|
@spekulatius Review the French translations especially first-level headings under Cheers |
|
Cool, thank you! |
Let's work on this here.