Add various improvements #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
April 2, 2019 13:41
- This ensures the integrity of the package - And addresses malicious tampering - Also added release parameter for download_url
|
awesome -- thanks @martialblog! |
walkamongus
pushed a commit
that referenced
this pull request
Apr 4, 2020
Additional swagger client settings
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
I've added some stuff:
The setting was < 5.0.0, but the stdlib is at 5.2.0 currently. Now the warning is gone and the installation runs without issues.
This ensures the integrity of the package and addresses malicious tampering. I also updated to 1.7.5, which required an extra parameter (release), since the download URL is:
https://storage.googleapis.com/harbor-releases/release-1.7.0/harbor-offline-installer-v1.7.5.tgz
By adding puppetlabs-apt and updating the exec resource. Tested that in Vagrant, works like a charm 馃惓
You can drop these is you want, just thought it might be nice to have.
Cheers,
Markus