Conceal the AD join password using an ENV var #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without this patch the AD join password is shown in the Puppet logs:
Aug 15 16:42:10 agent1 puppet-agent[2476]: \
(/Stage[main]/Realmd::Join::Password/Exec[realm_join_with_password]/returns) \
change from notrun to 0 failed: echo Password1' | realm join puppet.vm \
--unattended --user=Administrator returned 1 instead of one of [0]
This patch addresses the problem by wrapping the redirection in a shell script
and reading the password from an environment variable set by Puppet. This
prevents the password from showing up in the Puppet logs or in the process
table.
Resolves walkamongus#9
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this patch the AD join password is shown in the Puppet logs:
This patch addresses the problem by wrapping the redirection in a shell script
and reading the password from an environment variable set by Puppet. This
prevents the password from showing up in the Puppet logs or in the process
table.
Resolves #9