Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: code improvements with php_codesniffer without affecting logic, part 1 #294

Merged
merged 2 commits into from Jul 18, 2023

Conversation

marcosmarcolin
Copy link
Collaborator

Hello,

don't be scared by so many changes, they don't change the operating logic at all, it's just code quality.

I'm interested in contributing more to the project, and would start by updating parts of the code to industry-accepted standards.

I'll separate it into 'small' parts to make it less difficult to review, if you accept it of course (:

I installed squizlabs/php_codesniffer initially.

To review the code, run vendor/bin/phpcs src, to automatically correct use: vendor/bin/phpcbf src.

Well, that's it, it went well.

@walkor walkor merged commit 902ab18 into walkor:master Jul 18, 2023
@walkor
Copy link
Owner

walkor commented Jul 18, 2023

Merged and thank you for your effort in improving the code quality. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants