refactor: code improvements with php_codesniffer without affecting logic, part 1 #294
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
don't be scared by so many changes, they don't change the operating logic at all, it's just code quality.
I'm interested in contributing more to the project, and would start by updating parts of the code to industry-accepted standards.
I'll separate it into 'small' parts to make it less difficult to review, if you accept it of course (:
I installed squizlabs/php_codesniffer initially.
To review the code, run
vendor/bin/phpcs src
, to automatically correct use:vendor/bin/phpcbf src
.Well, that's it, it went well.