New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: code improvements without affecting logic, part 3. #297

Merged

walkor merged 1 commit into walkor:master from marcosmarcolin:refactor-part-3

Jul 23, 2023

Collaborator

marcosmarcolin commented Jul 22, 2023

Typed returns
Micro-optimizations
Update some phpdoc comment blocks
Remove some unused or unexpected parameters
Declare some attributes

As there are no unit tests yet, I tested it in a real application, and it didn't imply in the operation, everything ok.

I would like to test it in real life too.


          refactor: code improvements without affecting logic, part 3.

d4e001e

walkor merged commit 0ecabe7 into walkor:master

Owner

walkor commented Jul 23, 2023

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment