Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove non-php code #298

Merged
merged 1 commit into from Aug 16, 2023
Merged

Conversation

marcosmarcolin
Copy link
Collaborator

I'm mainly removing parts of the Decoder Method ->add($obj), I don't see the point in some parts, if the code being executed will generate a FATAL ERROR, non-existent class or non-existent function.

I believe it is some code that is not executed, what do you think?

@walkor walkor merged commit 48a5baa into walkor:master Aug 16, 2023
@walkor
Copy link
Owner

walkor commented Aug 16, 2023

phpsocket.io is a project I worked on a long time ago. At that time, I simply translated the code of socket.io using workerman, without delving into the internal details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants