Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: code improvements without affecting logic, part 4. #300

Merged
merged 2 commits into from Oct 13, 2023

Conversation

marcosmarcolin
Copy link
Collaborator

Hello,

I'm proposing some improvements in the quality of the code, as we don't have a test suite at the moment, I'm testing it on a real application and it's working correctly.

@walkor The engine you transcribed the code from https://github.com/socketio/engine.io/tree/2.1.x, right?

Did you base the other parts on any other socket.io server development or did you develop them yourself?

I ask this because I'm interested in trying to make the package comply with version 3 of socket.io first.

Thanks.

@walkor walkor merged commit c58667e into walkor:master Oct 13, 2023
@walkor
Copy link
Owner

walkor commented Oct 13, 2023

Yes, I transcribed the code directly from https://github.com/socketio/engine.io and https://github.com/socketio/socket.io, but I'm not sure about the specific version numbers. It would be great if you could implement version 3 of socket.io.

@walkor
Copy link
Owner

walkor commented Oct 13, 2023

I have added you to the project, and of course, you can also create a separate project. I will include a link to your project in this one.

@marcosmarcolin
Copy link
Collaborator Author

Hello,

Thank you very much for your trust.

I'm going to dedicate some time to this, as much as possible I hope to help make it compatible with newer versions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants