Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add compatibility for PHP 8.2 #304

Merged
merged 1 commit into from Apr 8, 2024

Conversation

i-derevianko
Copy link

No description provided.

@marcosmarcolin
Copy link
Collaborator

marcosmarcolin commented Apr 4, 2024

Hello @i-derevianko, firstly, thank you for your PR!

The user tested previous versions and confirmed that the code worked correctly.

What was the error that prompted the PR? Undefined properties?

For me, LGTM.

@walkor Do you agree?

@i-derevianko
Copy link
Author

Hi @marcosmarcolin!
Yeah, undefined properties mostly, and problem with the parent class calling.

@i-derevianko
Copy link
Author

i-derevianko commented Apr 5, 2024

@marcosmarcolin @walkor

Found some problem. There is differences between release v2.0.3 and repo.

For example https://github.com/walkor/phpsocket.io/blob/master/src/Engine/Socket.php#L24

There is
public $upgradeTransport = null; public $transport = null;

But there is no this attributes in release v2.0.3. Check it please before merge.

@marcosmarcolin
Copy link
Collaborator

marcosmarcolin commented Apr 5, 2024

@i-derevianko

Yes, after version v2.0.3 there were changes to the code, but a version was not released.

We can see all the changes after the mentioned version here: v2.0.3...master

@walkor I just released version v2.0.4 with the new changes.

@walkor
Copy link
Owner

walkor commented Apr 6, 2024

@i-derevianko
Thank you for your PR.

@marcosmarcolin
That great , thank you for your release.

@marcosmarcolin marcosmarcolin changed the title php 8.2 compatibility feat: add compatibility for PHP 8.2 Apr 8, 2024
@marcosmarcolin marcosmarcolin merged commit c9fa2e5 into walkor:master Apr 8, 2024
@marcosmarcolin
Copy link
Collaborator

Thanks @i-derevianko!

Released v2.1.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants