Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found the problem with the Feature Tests in Adapterman.
The test stop, and never finish, when testing a bad request.
The problem is that the client is waiting for the body or close.
Testing direct with curl:
and wait here, till I press Ctrl+c
Now:
The curios thing is that the
400 Bad Request
is Unit tested in this repo without problems.For that we need more Feature Tests.
All the Adapterman Feature Tests work with Workerman.
When they are more polished, I'll create a PR to add it to Workerman.
Update: perhaps will be better to close the connection, like you want.