Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 400 Bad Request #922

Merged
merged 1 commit into from Jun 28, 2023
Merged

Fix 400 Bad Request #922

merged 1 commit into from Jun 28, 2023

Conversation

joanhey
Copy link
Contributor

@joanhey joanhey commented Jun 28, 2023

I found the problem with the Feature Tests in Adapterman.

The test stop, and never finish, when testing a bad request.
The problem is that the client is waiting for the body or close.

Testing direct with curl:
image
and wait here, till I press Ctrl+c

Now:
image

The curios thing is that the 400 Bad Request is Unit tested in this repo without problems.
For that we need more Feature Tests.

All the Adapterman Feature Tests work with Workerman.
When they are more polished, I'll create a PR to add it to Workerman.

Update: perhaps will be better to close the connection, like you want.

@walkor walkor merged commit 4bde503 into walkor:master Jun 28, 2023
4 checks passed
@walkor
Copy link
Owner

walkor commented Jun 28, 2023

Thanks

@joanhey joanhey deleted the fix-400-bad-request branch June 28, 2023 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants